Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RE files to under "export" #96

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Move RE files to under "export" #96

merged 2 commits into from
Oct 30, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Oct 30, 2024 •
edited
Loading

On the CTM platform, it appears that only the export subdirectory of the report outputs directory is exposed tot he user. This PR places the RE PDF files in report/export rather than report/real_estate

Test Results: https://beta.transitionmonitor.com/pacta/share/bc86ff7a-5ed4-4acb-9814-3cf06080d5df

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.80%. Comparing base (21e4ab0) to head (a0fa359).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/create_interactive_report.R 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main     #96   +/-   ##
=====================================
  Coverage   0.80%   0.80%           
=====================================
  Files         25      25           
  Lines       1617    1617           
=====================================
  Hits          13      13           
  Misses      1604    1604

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm mentioned this pull request Oct 30, 2024
Closed
@AlexAxthelm AlexAxthelm requested a review from jdhoffa October 30, 2024 14:55
@AlexAxthelm AlexAxthelm marked this pull request as ready for review October 30, 2024 14:56
@AlexAxthelm AlexAxthelm requested a review from MonikaFu as a code owner October 30, 2024 14:56
MonikaFu
MonikaFu approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we also adjust user results generation accordingly?

@AlexAxthelm
Copy link
Collaborator Author

No adjustment needed. This is just changing the step where we copy the PDFs from inputs to outputs as part of create_interactive_report

@AlexAxthelm AlexAxthelm merged commit eb22d8f into main Oct 30, 2024
9 checks passed
@AlexAxthelm AlexAxthelm deleted the fix-re-links branch October 30, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonikaFu MonikaFu MonikaFu approved these changes

@jdhoffa jdhoffa Awaiting requested review from jdhoffa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @MonikaFu